linux-kernel - Re: [RFC 07/25] leds: Add Titan Micro Electronics TM1628

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7441a2d5-f10a-8ca9-8df9-10c0a78cbeb7@suse.de>
Date:   Sat, 14 Dec 2019 10:48:04 +0100
From:   Andreas Färber <afaerber@...e.de>
To:     linux-realtek-soc@...ts.infradead.org, linux-leds@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>,
        linux-arm-kernel@...ts.infradead.org, Dan Murphy <dmurphy@...com>
Subject: Re: [RFC 07/25] leds: Add Titan Micro Electronics TM1628

Am 12.12.19 um 04:39 schrieb Andreas Färber:
> diff --git a/drivers/leds/leds-tm1628.c b/drivers/leds/leds-tm1628.c
> new file mode 100644
> index 000000000000..319bf34ce835
> --- /dev/null
> +++ b/drivers/leds/leds-tm1628.c
[...]
> +struct tm1628 {
> +	struct spi_device		*spi;
> +	const struct tm1628_info	*info;

> +	u32				grids;
> +	unsigned int			segments;

These fields were unused since introducing mode_index, dropping.

> +	int				mode_index;
> +	int				pwm_index;
> +	u8				data[14];
> +	unsigned int			num_leds;
> +	struct tm1628_led		leds[];
> +};
Regards,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)