linux-kernel - Re: [PATCH] platform/chrome: cros_ec_lpc: Use platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2139eca-6561-a353-576f-cf6c53e5441f@collabora.com>
Date:   Sat, 14 Dec 2019 12:53:11 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Guenter Roeck <groeck@...gle.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Collabora Kernel ML <kernel@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Dmitry Torokhov <dtor@...omium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: Use
 platform_get_irq_optional() for optional IRQs

Hi,

On 29/11/19 16:56, Guenter Roeck wrote:
> On Fri, Nov 29, 2019 at 2:23 AM Enric Balletbo i Serra
> <enric.balletbo@...labora.com> wrote:
>>
>> As platform_get_irq() now prints an error when the interrupt does not
>> exist, use platform_get_irq_optional() to get the IRQ which is optional
>> to avoid below error message during probe:
>>
>>   [    5.113502] cros_ec_lpcs GOOG0004:00: IRQ index 0 not found
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> 
> Reviewed-by: Guenter Roeck <groeck@...omium.org>
> 

Queued for 5.6.

>> ---
>>
>>  drivers/platform/chrome/cros_ec_lpc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
>> index dccf479c6625..ffdea7c347f2 100644
>> --- a/drivers/platform/chrome/cros_ec_lpc.c
>> +++ b/drivers/platform/chrome/cros_ec_lpc.c
>> @@ -396,7 +396,7 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>>          * Some boards do not have an IRQ allotted for cros_ec_lpc,
>>          * which makes ENXIO an expected (and safe) scenario.
>>          */
>> -       irq = platform_get_irq(pdev, 0);
>> +       irq = platform_get_irq_optional(pdev, 0);
>>         if (irq > 0)
>>                 ec_dev->irq = irq;
>>         else if (irq != -ENXIO) {
>> --
>> 2.20.1
>>
>