linux-kernel - Re: [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGTfZH2CS6o-zaHXReKJXzxsU_jfYKg2WL7uGpzyaFNhgTSVbg@mail.gmail.com>
Date:   Mon, 16 Dec 2019 00:30:57 +0900
From:   Chanwoo Choi <chanwoo@...nel.org>
To:     Yangtao Li <tiny.windzz@...il.com>
Cc:     Chanwoo Choi <cw00.choi@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Heiko Stübner <heiko@...ech.de>,
        Linux PM list <linux-pm@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put()

2019년 12월 15일 (일) 오전 3:12, Yangtao Li <tiny.windzz@...il.com>님이 작성:
>
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/devfreq/event/rockchip-dfi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> index 5d1042188727..45b190e443d8 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
>         node = of_parse_phandle(np, "rockchip,pmu", 0);
>         if (node) {
>                 data->regmap_pmu = syscon_node_to_regmap(node);
> +               of_node_put(node);
>                 if (IS_ERR(data->regmap_pmu))
>                         return PTR_ERR(data->regmap_pmu);
>         }
> --
> 2.17.1
>

Applied it. Better to use the capital letter for first char of sentence.

-- 
Best Regards,
Chanwoo Choi