linux-kernel - Re: [PATCH 07/55] staging: wfx: ensure that retry policy always fallbacks to MCS0 / 1Mbps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0777ef33-e1f4-148a-40cb-cfe7b42d5364@nbd.name>
Date:   Mon, 16 Dec 2019 19:08:39 +0100
From:   Felix Fietkau <nbd@....name>
To:     Jérôme Pouiller <Jerome.Pouiller@...abs.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 07/55] staging: wfx: ensure that retry policy always
 fallbacks to MCS0 / 1Mbps

On 2019-12-16 18:03, Jérôme Pouiller wrote:
> From: Jérôme Pouiller <jerome.pouiller@...abs.com>
> 
> When not using HT mode, minstrel always includes 1Mbps as fallback rate.
> But, when using HT mode, this fallback is not included. Yet, it seems
> that it could save some frames. So, this patch add it unconditionally.
> 
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com>
Are you sure that's a good idea? Sometimes a little packet loss can be
preferable over a larger amount of airtime wasted through using really
low rates. Especially when you consider bufferbloat.

- Felix