linux-kernel - [PATCH 1/2] arm64: dts: qcom: sm8150: Update UFS resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191216183232.1570675-1-vkoul@kernel.org>
Date:   Tue, 17 Dec 2019 00:02:31 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 1/2] arm64: dts: qcom: sm8150: Update UFS resets

The reset described is the phy reset so it should be named ufsphy, so
update it and add the UFS card reset

Earlier reset description was incorrect as phy reset was pointed to
'rst' as well as 'ufsphy' so both phy and core attempted to reset this
causing UFS to not come up. This was discovered with 870b1279c7a0
("scsi: ufs-qcom: Add reset control support for host controller")

Signed-off-by: Vinod Koul <vkoul@...nel.org>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index f36d621a53e2..6a351e0cb3a6 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -517,8 +517,9 @@
 			phy-names = "ufsphy";
 			lanes-per-direction = <2>;
 			#reset-cells = <1>;
-			resets = <&gcc GCC_UFS_PHY_BCR>;
-			reset-names = "rst";
+			resets = <&gcc GCC_UFS_PHY_BCR>,
+				 <&gcc GCC_UFS_CARD_BCR>;
+			reset-names = "ufsphy", "rst";
 
 			clock-names =
 				"core_clk",
-- 
2.23.0