linux-kernel - Re: [PATCH] NFSv4: open() should try lease recovery on NFS4ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4876605a6f7387d04986a16f2f16c4014c49c734.camel@hammerspace.com>
Date:   Mon, 16 Dec 2019 18:39:54 +0000
From:   Trond Myklebust <trondmy@...merspace.com>
To:     "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "rmilkowski@...il.com" <rmilkowski@...il.com>
CC:     "anna.schumaker@...app.com" <anna.schumaker@...app.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] NFSv4: open() should try lease recovery on
 NFS4ERR_EXPIRED

On Mon, 2019-12-16 at 17:54 +0000, Robert Milkowski wrote:
> From: Robert Milkowski <rmilkowski@...il.com>
> 
> Currently, if an nfs server returns NFS4ERR_EXPIRED to open,
> we return EIO to applications without even trying to recover.
> 
> Signed-off-by: Robert Milkowski <rmilkowski@...il.com>
> ---
>  fs/nfs/nfs4proc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index aad65dd..04e6a13 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -481,6 +481,10 @@ static int nfs4_do_handle_exception(struct
> nfs_server
> *server,
>  						stateid);
>  				goto wait_on_recovery;
>  			}
> +			if (state == NULL) {
> +				nfs4_schedule_lease_recovery(clp);
> +				goto wait_on_recovery;
> +			}
>  			/* Fall through */
>  		case -NFS4ERR_OPENMODE:
>  			if (inode) {

Ugh. If we need a state==NULL for NFSv4.0, then let's get rid of the
switch() fall through in the above case, and rather add a delegation
return to the EXPIRED handling.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@...merspace.com