linux-kernel - Re: [PATCH 1/2] dt-bindings: power: rpmpd: Convert rpmpd bindings to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5df7dc77.1c69fb81.9e37f.16a5@mx.google.com>
Date:   Mon, 16 Dec 2019 11:35:18 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Sibi Sankar <sibis@...eaurora.org>, bjorn.andersson@...aro.org,
        rnayak@...eaurora.org, robh+dt@...nel.org
Cc:     agross@...nel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        mark.rutland@....com, dianders@...omium.org,
        Sibi Sankar <sibis@...eaurora.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: rpmpd: Convert rpmpd bindings to yaml

Quoting Sibi Sankar (2019-12-16 03:55:30)
> Convert RPM/RPMH power-domain bindings to yaml.
> 
> Signed-off-by: Sibi Sankar <sibis@...eaurora.org>

Reviewed-by: Stephen Boyd <swboyd@...omium.org>

One nitpick below!

> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> new file mode 100644
> index 0000000000000..4aebf024e4427
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> @@ -0,0 +1,170 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/qcom,rpmpd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm RPM/RPMh Power domains
> +
> +maintainers:
> +  - Rajendra Nayak <rnayak@...eaurora.org>
> +
> +description:
> +  For RPM/RPMh Power domains, we communicate a performance state to RPM/RPMh
> +  which then translates it into a corresponding voltage on a rail

Add a full-stop here to make it a true sentence?

> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,msm8976-rpmpd
> +      - qcom,msm8996-rpmpd
> +      - qcom,msm8998-rpmpd
> +      - qcom,qcs404-rpmpd
> +      - qcom,sc7180-rpmhpd
> +      - qcom,sdm845-rpmhpd
> +      - qcom,sm8150-rpmhpd
> +