linux-kernel - Re: [PATCH 12/17] clk: socfpga: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ebd88a1-7b04-a6e6-cffc-59353a6846dc@kernel.org>
Date:   Mon, 16 Dec 2019 14:20:50 -0600
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Yangtao Li <tiny.windzz@...il.com>, afaerber@...e.de,
        manivannan.sadhasivam@...aro.org, mturquette@...libre.com,
        sboyd@...nel.org, Eugeniy.Paltsev@...opsys.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, agross@...nel.org,
        s.nawrocki@...sung.com, tomasz.figa@...il.com,
        cw00.choi@...sung.com, kgene@...nel.org, krzk@...nel.org,
        palmer@...ive.com, paul.walmsley@...ive.com, mripard@...nel.org,
        wens@...e.org, emilio@...pez.com.ar, pdeschrijver@...dia.com,
        pgaikwad@...dia.com, thierry.reding@...il.com,
        jonathanh@...dia.com, matthias.bgg@...il.com, rfontana@...hat.com,
        gregkh@...uxfoundation.org, t-kristo@...com, john@...ozen.org,
        tglx@...utronix.de, allison@...utok.net,
        kstewart@...uxfoundation.org, swinslow@...il.com,
        aisheng.dong@....com, robh@...nel.org, daniel.baluta@....com,
        weiyongjun1@...wei.com, wangyan.wang@...iatek.com,
        chunhui.dai@...iatek.com, miquel.raynal@...tlin.com,
        heiko@...ech.de, jcmvbkbc@...il.com, nsekhar@...com,
        geert+renesas@...der.be
Cc:     linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-tegra@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 12/17] clk: socfpga: convert to
 devm_platform_ioremap_resource



On 12/9/19 1:57 PM, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/clk/socfpga/clk-s10.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/socfpga/clk-s10.c b/drivers/clk/socfpga/clk-s10.c
> index 993f3a73c71e..85055fc56404 100644
> --- a/drivers/clk/socfpga/clk-s10.c
> +++ b/drivers/clk/socfpga/clk-s10.c
> @@ -276,11 +276,9 @@ static struct stratix10_clock_data *__socfpga_s10_clk_init(struct platform_devic
>  	struct device *dev = &pdev->dev;
>  	struct stratix10_clock_data *clk_data;
>  	struct clk **clk_table;
> -	struct resource *res;
>  	void __iomem *base;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(dev, res);
> +	base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base)) {
>  		pr_err("%s: failed to map clock registers\n", __func__);
>  		return ERR_CAST(base);
> 

Tested-by: Dinh Nguyen <dinguyen@...nel.org>