linux-kernel - Re: [PATCH v2] tty/serial: atmel: fix out of range clock divider handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39e4d1c7-20b0-a024-3a46-e4d4369eed8e@sysgo.com>
Date:   Mon, 16 Dec 2019 09:34:09 +0100
From:   David Engraf <david.engraf@...go.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     richard.genoud@...il.com, jslaby@...e.com,
        nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        ludovic.desroches@...rochip.com, linux-serial@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tty/serial: atmel: fix out of range clock divider
 handling

On 13.12.19 at 17:07, Greg KH wrote:
> On Fri, Dec 13, 2019 at 03:03:01PM +0100, David Engraf wrote:
>> Use MCK_DIV8 when the clock divider is > 65535. Unfortunately the mode
>> register was already written thus the clock selection is ignored.
>>
>> Fix by doing the baud rate calulation before setting the mode.
>>
>> Fixes: 5bf5635ac170 ("tty/serial: atmel: add fractional baud rate support")
>> Signed-off-by: David Engraf <david.engraf@...go.com>
>> ---
>>   drivers/tty/serial/atmel_serial.c | 43 ++++++++++++++++---------------
>>   1 file changed, 22 insertions(+), 21 deletions(-)
> 
> What changed from v1?
> 
> Always put that below the --- line.

Oh sorry.

> v3 please?

Sure.

Best regards
- David

> thanks,
> 
> greg k-h
>