linux-kernel - Re: [PATCH] EDAC: remove set but not used variable 'ecc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adf6f7d0-5e92-78a0-7b2e-7252e3eec99c@huawei.com>
Date:   Mon, 16 Dec 2019 09:11:54 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     "Luck, Tony" <tony.luck@...el.com>
CC:     <bp@...en8.de>, <mchehab@...nel.org>, <james.morse@....com>,
        <rrichter@...vell.com>, <zhengbin13@...wei.com>,
        <yi.zhang@...wei.com>, <linux-edac@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] EDAC: remove set but not used variable 'ecc_loc'



On 2019/12/14 7:11, Luck, Tony wrote:
> On Fri, Dec 13, 2019 at 08:10:36PM +0800, yu kuai wrote:
>> @@ -499,7 +498,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
>>   		pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
>>   		syndrome = dw2;
>>   		pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
>> -		ecc_loc = i5100_redmemb_ecc_locator(dw2);
>>   	}
>>   
>>   	if (i5100_validlog_recmemvalid(dw)) {
> 
> This deletes the only call to i5100_redmemb_ecc_locator(). Should
> we delete the definition of the function too?
Thank you for your response!
Yes, I think we can do that.

Thanks
Yu Kuai
> 
> Is it worth making cosmetic cleanups to a driver for 12 year old h/w?
> 
> -Tony
> 
> .
>