lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 16 Dec 2019 11:22:33 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Aditya Pakki <pakki001@....edu>, linux-media@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Hans Verkuil <hverkuil@...all.nl>,
        Kangjie Lu <kjlu@....edu>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] media: saa7146: Avoid using BUG_ON as an assertion

…
> +++ b/drivers/media/common/saa7146/saa7146_video.c
@@ -345,7 +345,8 @@ static int video_begin(struct saa7146_fh *fh)
…
-	BUG_ON(NULL == fmt);
+	if (NULL == fmt)
…

Would you like to express a null pointer check in a succinct way?

+	if (!fmt)


Will the tag “Fixes” become helpful for the change description?

Regards,
Markus

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ