linux-kernel - [PATCH v2] x86-64/entry: add instruction suffix to SYSRET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <038a7c35-062b-a285-c6d2-653b56585844@suse.com>
Date:   Mon, 16 Dec 2019 11:40:03 +0100
From:   Jan Beulich <jbeulich@...e.com>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     the arch/x86 maintainers <x86@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH v2] x86-64/entry: add instruction suffix to SYSRET

ignore_sysret contains an unsuffixed 'sysret' instruction.  gas
correctly interprets this as sysretl, but leaving it up to gas to
guess when there is no register operand that implies a size is bad
practice, and upstream gas is likely to warn about this in the future.
Use 'sysretl' explicitly.  This does not change the assembled output.

Signed-off-by: Jan Beulich <jbeulich@...e.com>
Acked-by: Andy Lutomirski <luto@...nel.org>
---
v2: Use re-written description from Andy.

--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -1728,7 +1728,7 @@ END(nmi)
 SYM_CODE_START(ignore_sysret)
 	UNWIND_HINT_EMPTY
 	mov	$-ENOSYS, %eax
-	sysret
+	sysretl
 SYM_CODE_END(ignore_sysret)
 #endif