linux-kernel - Re: [PATCH V2] ext4: use rcu API in debug_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191216024154.GB11512@mit.edu>
Date:   Sun, 15 Dec 2019 21:41:54 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Phong Tran <tranmanphong@...il.com>
Cc:     jack@...e.cz, adilger.kernel@...ger.ca, paulmck@...nel.org,
        joel@...lfernandes.org, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org, rcu@...r.kernel.org
Subject: Re: [PATCH V2] ext4: use rcu API in debug_print_tree

On Fri, Dec 13, 2019 at 10:33:07PM +0700, Phong Tran wrote:
> struct ext4_sb_info.system_blks was marked __rcu.
> But access the pointer without using RCU lock and dereference.
> Sparse warning with __rcu notation:
> 
> block_validity.c:139:29: warning: incorrect type in argument 1 (different address spaces)
> block_validity.c:139:29:    expected struct rb_root const *
> block_validity.c:139:29:    got struct rb_root [noderef] <asn:4> *
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> Signed-off-by: Phong Tran <tranmanphong@...il.com>

Applied, thanks.

						- Ted