linux-kernel - Re: [PATCH v15 0/7] mm / virtio: Provide support for free page reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d105f489-5c37-c60b-7464-801b36b976eb@redhat.com>
Date:   Mon, 16 Dec 2019 13:21:54 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        kvm@...r.kernel.org, mst@...hat.com, linux-kernel@...r.kernel.org,
        willy@...radead.org, mhocko@...nel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, mgorman@...hsingularity.net,
        vbabka@...e.cz
Cc:     yang.zhang.wz@...il.com, nitesh@...hat.com, konrad.wilk@...cle.com,
        pagupta@...hat.com, riel@...riel.com, lcapitulino@...hat.com,
        dave.hansen@...el.com, wei.w.wang@...el.com, aarcange@...hat.com,
        pbonzini@...hat.com, dan.j.williams@...el.com, osalvador@...e.de
Subject: Re: [PATCH v15 0/7] mm / virtio: Provide support for free page
 reporting

> I found alternative approaches and did away with most of them. What I had
> done is replaced the REPORTING_REQUESTED and reference count logic with
> the state in order to guarantee that we will make our way through the list
> and rearm the reporting thread if the work isn't completed.
> 
> One thing I still think I need to split out based on Mel's comments is the
> list rotation and probably the new budget value I added.

Yeah, both probably make sense.

> 
> As far as performance this new patch set performs better than the old one
> did. Most of that is due to the fact that I increased the delay between
> passes and dropped any optimizations for the shuffling code.

That's interesting - and good :)

I probably won't have enough time to look into #4 before Christmas - so
I might wait for your resend and review after Christmas.

-- 
Thanks,

David / dhildenb