linux-kernel - Re: [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Dec 2019 08:01:14 -0500
From:   "Andrew F. Davis" <afd@...com>
To:     zhong jiang <zhongjiang@...wei.com>, <sumit.semwal@...aro.org>,
        <benjamin.gaignard@...aro.org>
CC:     <lmark@...eaurora.org>, <labbott@...hat.com>,
        <Brian.Starkey@....com>, <john.stultz@...aro.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static

On 12/16/19 5:08 AM, zhong jiang wrote:
> Fix the following sparse warning.
> 
> drivers/gpu/drm/ast/ast_main.c:391:22: warning: symbol 'ast_mode_config_mode_valid' was not declared. Should it be static?
> 


The patch looks valid, but this commit message does not seem to match..

Andrew


> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/dma-buf/dma-heap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
> index 4f04d10..da2090e 100644
> --- a/drivers/dma-buf/dma-heap.c
> +++ b/drivers/dma-buf/dma-heap.c
> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
>  	return 0;
>  }
>  
> -unsigned int dma_heap_ioctl_cmds[] = {
> +static unsigned int dma_heap_ioctl_cmds[] = {
>  	DMA_HEAP_IOC_ALLOC,
>  };
>  
>