linux-kernel - Re: [PATCH 1/3] clocksource: em_sti: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ceabec4e-0b4b-ee31-e99b-ac62a03e3aeb@linaro.org>
Date:   Mon, 16 Dec 2019 14:44:17 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Yangtao Li <tiny.windzz@...il.com>, tglx@...utronix.de
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] clocksource: em_sti: convert to
 devm_platform_ioremap_resource

On 15/12/2019 16:17, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.

Even if the change is obvious, elaborate a bit the changelog.

> BTW, do another small cleanup.

Keep one change per patch.

> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/clocksource/em_sti.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
> index 9039df4f90e2..ab190dffb1ed 100644
> --- a/drivers/clocksource/em_sti.c
> +++ b/drivers/clocksource/em_sti.c
> @@ -279,9 +279,7 @@ static void em_sti_register_clockevent(struct em_sti_priv *p)
>  static int em_sti_probe(struct platform_device *pdev)
>  {
>  	struct em_sti_priv *p;
> -	struct resource *res;
> -	int irq;
> -	int ret;
> +	int irq, ret;
>  
>  	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
>  	if (p == NULL)
> @@ -295,8 +293,7 @@ static int em_sti_probe(struct platform_device *pdev)
>  		return irq;
>  
>  	/* map memory, let base point to the STI instance */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	p->base = devm_ioremap_resource(&pdev->dev, res);
> +	p->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(p->base))
>  		return PTR_ERR(p->base);
>  
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog