linux-kernel - Re: [PATCH] w1: omap-hdq: Simplify driver with PM runtime autosuspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Dec 2019 13:05:36 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Evgeniy Polyakov <zbr@...emap.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        Adam Ford <aford173@...il.com>,
        "Andrew F . Davis" <afd@...com>,
        "H . Nikolaus Schaller" <hns@...delico.com>,
        Vignesh R <vigneshr@...com>
Subject: Re: [PATCH] w1: omap-hdq: Simplify driver with PM runtime
 autosuspend

On Sun, 15 Dec 2019 19:16:37 -0800
Tony Lindgren <tony@...mide.com> wrote:

> * Tony Lindgren <tony@...mide.com> [191216 03:10]:
> > Hi,
> > 
> > * Andreas Kemnade <andreas@...nade.info> [191215 22:04]:  
> > > On Sun, 15 Dec 2019 09:38:17 -0800
> > > If I remember correctly this thing is critical to get the hwmod out of
> > > reset but I need to examine that again:  
> > 
> > Thanks for testing, yes that's what I thought might cause it
> > too, but nope :)
> > 
> > We currently disable interrupts for some reason after
> > the first read. That won't play with runtime PM autosuspend
> > at all as we never enable them again until the device has
> > idled. Can you try the following additional patch on top?  
> 
> And we should probably do the following too to make sure
> the mode is initialized before we call runtime PM.
> 
CM_FCLKEN1/IDLEST1_CORE seem to behave, reading also works 

With these two additional patches this deserves a
Tested-By: Andreas Kemnade <andreas@...nade.info> # gta04

Regards,
Andreas

Content of type "application/pgp-signature" skipped