linux-kernel - Re: [PATCH v4 01/12] add helpers for kelvin to/from Celsius conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAC5umyiZGzu3h9tUrSRWh6c6WLyUvXtdDvThw+VHoTjffBVNZA@mail.gmail.com>
Date:   Tue, 17 Dec 2019 00:02:32 +0900
From:   Akinobu Mita <akinobu.mita@...il.com>
To:     Matthew Wilcox <willy@...radead.org>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>,
        linux-hwmon@...r.kernel.org, Linux PM <linux-pm@...r.kernel.org>,
        "open list:TI WILINK WIRELES..." <linux-wireless@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v4 01/12] add helpers for kelvin to/from Celsius conversion

2019年12月16日(月) 12:25 Matthew Wilcox <willy@...radead.org>:
>
> > +static inline long milli_kelvin_to_millicelsius(long t)
> > +{
> > +     return t + ABSOLUTE_ZERO_MILLICELSIUS;
> > +}
>
> Why is there an underscore between 'milli' and 'kelvin', but not between
> 'milli' and 'celsius'?

Because these function names are derived from the existing macros in
linux/thermal.h.

Does anyone have a preference for the underscore in these function names?

1. underscore between unit prefix and 'kelvin,
   no underscore between unit prefix and 'celsius'
   (e.g. milli_kelvin_to_millicelsius, deci_kelvin_to_millicelsius, ...)

2. underscore between unit prefix and 'kelvin,
   underscore between unit prefix and 'celsius'
   (e.g. milli_kelvin_to_milli_celsius, deci_kelvin_to_milli_celsius, ...)

3. no underscore between unit prefix and 'kelvin,
   no underscore between unit prefix and 'celsius'
   (e.g. millikelvin_to_millicelsius, decikelvin_to_millicelsius, ...)