linux-kernel - Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 00:16:18 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jack Ping CHNG <jack.ping.chng@...el.com>
Cc:     kbuild-all@...ts.01.org, devel@...verdev.osuosl.org,
        cheol.yong.kim@...el.com,
        Jack Ping CHNG <jack.ping.chng@...el.com>,
        andriy.shevchenko@...el.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Amireddy Mallikarjuna reddy 
        <mallikarjunax.reddy@...ux.intel.com>, gregkh@...uxfoundation.org,
        davem@...emloft.net
Subject: Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit
 Ethernet Switch (GSWIP) device driver

Hi Jack,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.5-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jack-Ping-CHNG/staging-intel-gwdpa-gswip-Introduce-Gigabit-Ethernet-Switch-GSWIP-device-driver/20191212-073318
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 4d17363db021311d0b5ad533bc9c438ed3177d7c
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   In file included from drivers/staging/intel-gwdpa/gswip/mac_cfg.c:5:0:
   drivers/staging/intel-gwdpa/gswip/mac_common.h: In function 'sw_write':
>> drivers/staging/intel-gwdpa/gswip/mac_common.h:175:2: error: implicit declaration of function 'writel'; did you mean 'sw_write'? [-Werror=implicit-function-declaration]
     writel(val, priv->sw + reg);
     ^~~~~~
     sw_write
   drivers/staging/intel-gwdpa/gswip/mac_common.h: In function 'sw_read':
>> drivers/staging/intel-gwdpa/gswip/mac_common.h:181:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
     return readl(priv->sw + reg);
            ^~~~~
   drivers/staging/intel-gwdpa/gswip/mac_cfg.c: In function 'mac_set_physpeed':
>> drivers/staging/intel-gwdpa/gswip/mac_cfg.c:55:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      sw_set_speed(priv, SPEED_10M);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/intel-gwdpa/gswip/mac_cfg.c:57:2: note: here
     case SPEED_XGMAC_100M:
     ^~~~
   drivers/staging/intel-gwdpa/gswip/mac_cfg.c:67:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      sw_set_speed(priv, SPEED_10M);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/intel-gwdpa/gswip/mac_cfg.c:69:2: note: here
     case SPEED_LMAC_100M:
     ^~~~
   cc1: some warnings being treated as errors
--
   In file included from drivers/staging/intel-gwdpa/gswip/gswip_mac.c:7:0:
   drivers/staging/intel-gwdpa/gswip/mac_common.h: In function 'sw_write':
>> drivers/staging/intel-gwdpa/gswip/mac_common.h:175:2: error: implicit declaration of function 'writel'; did you mean 'sw_write'? [-Werror=implicit-function-declaration]
     writel(val, priv->sw + reg);
     ^~~~~~
     sw_write
   drivers/staging/intel-gwdpa/gswip/mac_common.h: In function 'sw_read':
>> drivers/staging/intel-gwdpa/gswip/mac_common.h:181:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
     return readl(priv->sw + reg);
            ^~~~~
   cc1: some warnings being treated as errors

vim +175 drivers/staging/intel-gwdpa/gswip/mac_common.h

   171	
   172	/*  GSWIP-O Top Register write */
   173	static inline void sw_write(struct gswip_mac *priv, u32 reg, u32 val)
   174	{
 > 175		writel(val, priv->sw + reg);
   176	}
   177	
   178	/* GSWIP-O Top Register read */
   179	static inline int sw_read(struct gswip_mac *priv, u32 reg)
   180	{
 > 181		return readl(priv->sw + reg);
   182	}
   183	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (57234 bytes)