linux-kernel - Re: [PATCH] mt76: fix LED link time failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c029f35a-6fd9-fc69-aa8f-16b66235f71e@nbd.name>
Date:   Tue, 17 Dec 2019 15:59:22 +0100
From:   Felix Fietkau <nbd@....name>
To:     Kalle Valo <kvalo@...eaurora.org>, Arnd Bergmann <arnd@...db.de>
Cc:     Lorenzo Bianconi <lorenzo.bianconi83@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Ryder Lee <ryder.lee@...iatek.com>,
        Roy Luo <royluo@...gle.com>,
        Stanislaw Gruszka <sgruszka@...hat.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mt76: fix LED link time failure

On 2019-12-17 15:35, Kalle Valo wrote:
> Arnd Bergmann <arnd@...db.de> writes:
> 
>> The mt76_led_cleanup() function is called unconditionally, which
>> leads to a link error when CONFIG_LEDS is a loadable module or
>> disabled but mt76 is built-in:
>>
>> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
>> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
>>
>> Use the same trick that is guarding the registration, using an
>> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
>> whether LEDs can be used or not.
>>
>> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Felix, as this is a regression in v5.5-rc1 can I take this directly to
> wireless-drivers?
Yes. Please add:
Acked-by: Felix Fietkau <nbd@....name>

- Felix