linux-kernel - Re: [PATCH v2 1/2] usbip: Fix receive error in vhci-hcd when using scatter-gather

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 08:20:13 -0700
From:   shuah <shuah@...nel.org>
To:     Suwan Kim <suwan.kim027@...il.com>, valentina.manea.m@...il.com,
        gregkh@...uxfoundation.org, marmarek@...isiblethingslab.com
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, stern@...land.harvard.edu,
        Shuah Khan <skhan@...uxfoundation.org>,
        shuah <shuah@...nel.org>
Subject: Re: [PATCH v2 1/2] usbip: Fix receive error in vhci-hcd when using
 scatter-gather

On 12/12/19 7:30 PM, Suwan Kim wrote:
> When vhci uses SG and receives data whose size is smaller than SG
> buffer size, it tries to receive more data even if it acutally
> receives all the data from the server. If then, it erroneously adds
> error event and triggers connection shutdown.
> 
> vhci-hcd should check if it received all the data even if there are
> more SG entries left. So, check if it receivces all the data from
> the server in for_each_sg() loop.
> 
> Fixes: ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub driver")
> Reported-by: Marek Marczykowski-Górecki <marmarek@...isiblethingslab.com>
> Tested-by: Marek Marczykowski-Górecki <marmarek@...isiblethingslab.com>
> Signed-off-by: Suwan Kim <suwan.kim027@...il.com>
> ---
>   drivers/usb/usbip/usbip_common.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
> index 6532d68e8808..e4b96674c405 100644
> --- a/drivers/usb/usbip/usbip_common.c
> +++ b/drivers/usb/usbip/usbip_common.c
> @@ -727,6 +727,9 @@ int usbip_recv_xbuff(struct usbip_device *ud, struct urb *urb)
>   
>   			copy -= recv;
>   			ret += recv;
> +
> +			if (!copy)
> +				break;
>   		}
>   
>   		if (ret != size)
> 

Thanks Marek and Suwan for taking care of this.

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah