linux-kernel - Re: [Y2038] [PATCH 10/24] compat_ioctl: cdrom: handle CDROM_LAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 15:20:14 +0000
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Arnd Bergmann <arnd@...db.de>, Jens Axboe <axboe@...nel.dk>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-block@...r.kernel.org
Cc:     Jonathan Corbet <corbet@....net>, y2038@...ts.linaro.org,
        linux-kernel@...r.kernel.org,
        Diego Elio Pettenò <flameeyes@...meeyes.com>,
        Hannes Reinecke <hare@...e.de>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Martin Wilck <mwilck@...e.com>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [Y2038] [PATCH 10/24] compat_ioctl: cdrom: handle
 CDROM_LAST_WRITTEN

On Wed, 2019-12-11 at 21:42 +0100, Arnd Bergmann wrote:
> This is the only ioctl command that does not have a proper
> compat handler. Making the normal implementation do the
> right thing is actually very simply, so just do that by
> using an in_compat_syscall() check to avoid the special
> case in the pkcdvd driver.
[...]

Since this uses blkdev_compat_ptr_ioctl() it needs to be moved after
the following patch.

Ben.

-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom