linux-kernel - Re: [PATCH] tty: serial: samsung_tty: do not abuse the struct uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 16:52:19 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dmitry Safonov <dima@...sta.com>
Cc:     Kukjin Kim <kgene@...nel.org>, Hyunki Koo <kkoos00@...er.com>,
        HYUN-KI KOO <hyunki00.koo@...sung.com>,
        Shinbeom Choi <sbeom.choi@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: serial: samsung_tty: do not abuse the struct
 uart_port unused fields

On Tue, Dec 17, 2019 at 03:47:34PM +0000, Dmitry Safonov wrote:
> On 12/17/19 2:02 PM, Greg Kroah-Hartman wrote:
> > The samsung_tty driver was trying to abuse the struct uart_port by using
> > two "empty" bytes for its own use.  That's not ok, and was found by
> > removing those fields from the structure.
> > 
> > Move the variables into the port-specific structure, which is where
> > everything else for this port already is.  There is no space wasted here
> > as there was an empty "hole" in the structure already for these bytes.
> 
> Thanks!
> Sorry for not noticing this myself.

You wouldn't have noticed this unless you build for that platform. I
just recently made it buildable for other ones.

> 
> > Cc: Kukjin Kim <kgene@...nel.org>
> > Cc: Hyunki Koo <kkoos00@...er.com>
> > Cc: HYUN-KI KOO <hyunki00.koo@...sung.com>
> > Cc: Shinbeom Choi <sbeom.choi@...sung.com>
> > Cc: Krzysztof Kozlowski <krzk@...nel.org>
> > Cc: Dmitry Safonov <dima@...sta.com>
> > Cc: Jiri Slaby <jslaby@...e.com>
> > Cc: linux-serial@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> I see you already applied it to your tree, but in case it helps anything:
> Reviewed-by: Dmitry Safonov <dima@...sta.com>

The review helps, thanks :)

greg k-h