linux-kernel - Re: [PATCH] dtc: checks: check_graph_port: skip node name check in overlay case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 10:06:29 -0600
From:   Benoit Parrot <bparrot@...com>
To:     Rob Herring <robh+dt@...nel.org>
CC:     Maxime Ripard <mripard@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        Jyri Sarha <jsarha@...com>
Subject: Re: [PATCH] dtc: checks: check_graph_port: skip node name check in
 overlay case

Ping!

Benoit Parrot <bparrot@...com> wrote on Fri [2019-Nov-22 13:16:31 -0600]:
> In check_graph_port() we need to skip the node name check in the overlay
> case as it causes a false positive warning.
> 
> Signed-off-by: Benoit Parrot <bparrot@...com>
> ---
>  checks.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/checks.c b/checks.c
> index 756f0fa9203f..6b6712da146a 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -1707,7 +1707,8 @@ static void check_graph_port(struct check *c, struct dt_info *dti,
>  	if (node->bus != &graph_port_bus)
>  		return;
>  
> -	if (!strprefixeq(node->name, node->basenamelen, "port"))
> +	if (!strprefixeq(node->name, node->basenamelen, "port") &&
> +	    !(dti->dtsflags & DTSF_PLUGIN))
>  		FAIL(c, dti, node, "graph port node name should be 'port'");
>  
>  	check_graph_reg(c, dti, node);