linux-kernel - Re: [PATCH 2/2] leds: lm3692x: Allow to set ovp and brigthness mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c233937-5d99-bd9d-b8ac-290fca8305d5@ti.com>
Date:   Tue, 17 Dec 2019 11:01:49 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Guido Günther <agx@...xcpu.org>
CC:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        <linux-leds@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] leds: lm3692x: Allow to set ovp and brigthness mode

Guido

On 12/17/19 9:40 AM, Guido Günther wrote:
> Hi Dan,
> On Tue, Dec 17, 2019 at 06:53:45AM -0600, Dan Murphy wrote:
>> Guido
>>
>> On 12/16/19 6:28 AM, Guido Günther wrote:
>>> Overvoltage protection and brightness mode are currently hardcoded
>>> as disabled in the driver. Make these configurable via DT.
>> Can we split these up to two separate patch series?
> Sure, should the binding doc updates be split as well?

Yes.

<snip>
>> extra debug statement
> They're not extra but meant to ease debugging the driver long therm but
> i can drop these if that's not wanted. The rest makes a lot of sense.
> Thanks a lot for having a look so promptly!

Yes please remove those we don't need extra noise in the log.

If someone wants to debug this then they can add the statements themselves

Dan