linux-kernel - Re: [PATCH] soc: ti: wkup_m3_ipc: Fix race condition with rproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191217183548.GE35479@atomide.com>
Date:   Tue, 17 Dec 2019 10:35:48 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     santosh.shilimkar@...cle.com
Cc:     Dave Gerlach <d-gerlach@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, Suman Anna <s-anna@...com>
Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: Fix race condition with rproc_boot

* santosh.shilimkar@...cle.com <santosh.shilimkar@...cle.com> [191217 18:33]:
> On 12/17/19 10:25 AM, Tony Lindgren wrote:
> > Hi,
> > 
> > * Dave Gerlach <d-gerlach@...com> [191211 20:02]:
> > > Any user of wkup_m3_ipc calls wkup_m3_ipc_get to get a handle and this
> > > checks the value of the static variable m3_ipc_state to see if the
> > > wkup_m3 is ready. Currently this is populated during probe before
> > > rproc_boot has been called, meaning there is a window of time that
> > > wkup_m3_ipc_get can return a valid handle but the wkup_m3 itself is not
> > > ready, leading to invalid IPC calls to the wkup_m3 and system
> > > instability.
> > > 
> > > To avoid this, move the population of the m3_ipc_state variable until
> > > after rproc_boot has succeeded to guarantee a valid and usable handle
> > > is always returned.
> > 
> > Santosh, do you want me to pick this one into my fixes branch?
> > 
> Sure, go ahead.
> 
> Acked-by: Santosh Shilimkar <ssantosh@...nel.org>

OK thanks applying into fixes.

Tony