[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20191217001934.GT3143381@builder>
Date: Mon, 16 Dec 2019 16:19:34 -0800
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Sibi Sankar <sibis@...eaurora.org>
Cc: jhugo@...eaurora.org, robh+dt@...nel.org, jonathan@...ek.ca,
ohad@...ery.com, mark.rutland@....com, p.zabel@...gutronix.de,
linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
agross@...nel.org
Subject: Re: [PATCH 16/16] arm64: dts: qcom: sm8150: Add ADSP, CDSP, MPSS and
SLPI remoteprocs
On Mon 18 Nov 13:44 PST 2019, Sibi Sankar wrote:
> Add ADSP, CDSP, MPSS and SLPI device tree nodes for SM8150 SoC.
>
> Signed-off-by: Sibi Sankar <sibis@...eaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 12 +++
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 135 ++++++++++++++++++++++++
> 2 files changed, 147 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
> index aa5de42fcae45..4d9bb8145dbba 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
> @@ -348,6 +348,18 @@
> };
> };
>
> +&adsp_pas {
> + status = "okay";
> +};
> +
> +&cdsp_pas {
> + status = "okay";
> +};
> +
> +&slpi_pas {
> + status = "okay";
> +};
> +
> &qupv3_id_1 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 98a96fd1d6117..58f4ce95bd966 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -5,6 +5,8 @@
> */
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/clock/qcom,gcc-sm8150.h>
> +#include <dt-bindings/power/qcom-aoss-qmp.h>
> #include <dt-bindings/power/qcom-rpmpd.h>
> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
> #include <dt-bindings/clock/qcom,rpmh.h>
> @@ -278,6 +280,139 @@
> };
> };
>
> + adsp_pas: remoteproc-adsp {
Please move this in under /soc, name it "remoteproc" and slap a reg = <>
on it. Even if qcom,*-pas doesn't use the information I find it look
better in the DT and it becomes more consistent between PAS and non-PAS
targets.
Regards,
Bjorn
Powered by blists - more mailing lists