linux-kernel - Re: [PATCH] scsi: RDMA/srpt: Fix incorrect pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4103701f-27f0-f856-7aae-97420b8236d2@acm.org>
Date:   Tue, 17 Dec 2019 11:33:45 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Aditya Pakki <pakki001@....edu>
Cc:     kjlu@....edu, Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: RDMA/srpt: Fix incorrect pointer dereference

On 12/17/19 11:26 AM, Aditya Pakki wrote:
> In srpt_queue_response(), the rdma channel ch is first
> dereferenced and then checked for NULL. This renders the
> assertion ineffective. This patch removes the assertion and
> avoids potential NULL pointer dereference.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---
>   drivers/infiniband/ulp/srpt/ib_srpt.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 23c782e3d49a..bbc6729c81c0 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -2803,15 +2803,17 @@ static void srpt_queue_response(struct se_cmd *cmd)
>   	struct srpt_send_ioctx *ioctx =
>   		container_of(cmd, struct srpt_send_ioctx, cmd);
>   	struct srpt_rdma_ch *ch = ioctx->ch;
> -	struct srpt_device *sdev = ch->sport->sdev;
>   	struct ib_send_wr send_wr, *first_wr = &send_wr;
> -	struct ib_sge sge;
>   	enum srpt_command_state state;
> +	struct srpt_device *sdev;
>   	int resp_len, ret, i;
> +	struct ib_sge sge;
>   	u8 srp_tm_status;
>   
> -	BUG_ON(!ch);
> +	if (WARN_ON(!ch))
> +		return;
>   
> +	sdev = ch->sport->sdev;
>   	state = ioctx->state;
>   	switch (state) {
>   	case SRPT_STATE_NEW:

Instead of making all these changes, please remove the BUG_ON(!ch) 
statement. If the condition ioctx->ch == NULL would ever be encountered 
then the call trace reported on the console will be sufficient to figure 
out what happened.

Thanks,

Bart.