linux-kernel - Re: [PATCH] random: don't forget compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 20:56:14 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] random: don't forget compat_ioctl on unrandom

On Tue, Dec 17, 2019 at 08:36:48PM +0100, Arnd Bergmann wrote:
> On Tue, Dec 17, 2019 at 6:25 PM Jason A. Donenfeld <Jason@...c4.com> wrote:
> >
> > Recently, there's been some compat ioctl cleanup, in which large
> > hardcoded lists were replaced with compat_ptr_ioctl. One of these
> > changes involved removing the random.c hardcoded list entries and adding
> > a compat ioctl function pointer to the random.c fops. In the process,
> > urandom was forgotten about, so this commit fixes that oversight.
> >
> > Fixes: 507e4e2b430b ("compat_ioctl: remove /dev/random commands")
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> 
> Thanks for debugging this. I had already sent the same
> patch a few days ago after the first report:
> 
> https://lore.kernel.org/lkml/20191207185837.4030699-1-arnd@arndb.de/
> 
> Greg, can you please apply one of these and send it to Linus for 5.5-rc3?

Ugh, I missed your first one, sorry, I thought that was for Ted and
missed that it was due to a patch that came from my tree.  I've queued
Jason's patch up now.

thanks,

greg k-h