linux-kernel - [PATCH] scsi: aic94xx: remove unnecessary assertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191217201914.27672-1-pakki001@umn.edu>
Date:   Tue, 17 Dec 2019 14:19:12 -0600
From:   Aditya Pakki <pakki001@....edu>
To:     pakki001@....edu
Cc:     kjlu@....edu, "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Allison Randal <allison@...utok.net>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: aic94xx: remove unnecessary assertion

In asd_unbuild_smp_ascb, the task is never NULL when called from
asd_execute_task and asd_task_tasklet_complete. The BUG_ON assertion
is thus unnecessary and can be removed.

Signed-off-by: Aditya Pakki <pakki001@....edu>
---
 drivers/scsi/aic94xx/aic94xx_task.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx/aic94xx_task.c
index f923ed019d4a..6aa75777fff1 100644
--- a/drivers/scsi/aic94xx/aic94xx_task.c
+++ b/drivers/scsi/aic94xx/aic94xx_task.c
@@ -452,7 +452,6 @@ static void asd_unbuild_smp_ascb(struct asd_ascb *a)
 {
 	struct sas_task *task = a->uldd_task;
 
-	BUG_ON(!task);
 	dma_unmap_sg(&a->ha->pcidev->dev, &task->smp_task.smp_req, 1,
 		     DMA_TO_DEVICE);
 	dma_unmap_sg(&a->ha->pcidev->dev, &task->smp_task.smp_resp, 1,
-- 
2.20.1