linux-kernel - Re: [PATCH v3 2/7] usb: musb: dma: Add support for shared IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 22:04:38 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Bin Liu <b-liu@...com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>, od@...c.me,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Artur Rojek <contact@...ur-rojek.eu>
Subject: Re: [PATCH v3 2/7] usb: musb: dma: Add support for shared IRQ

Hi Bin,


Le mar., déc. 17, 2019 at 08:42, Bin Liu <b-liu@...com> a écrit :
> Hi Paul,
> 
> On Wed, Dec 11, 2019 at 12:52:24PM -0600, Bin Liu wrote:
>>  On Tue, Dec 10, 2019 at 06:11:05PM +0100, Paul Cercueil wrote:
>>  > The implementation of the Inventra IP in some of the Ingenic 
>> JZ47xx SoCs
>>  > does not use a separate IRQ line for DMA transfers.
>>  >
>>  > Allow these SoCs to be supported by adding a flag 
>> 'dma_share_usb_irq'
>>  > in the struct musb. If set, no extra IRQ line is required, and 
>> the musb
>>  > glue will need to call the API function 
>> musbhs_dma_controller_irq()
>>  > within its interrupt handler.
>>  >
>>  > Signed-off-by: Paul Cercueil <paul@...pouillou.net>
>>  > Tested-by: Artur Rojek <contact@...ur-rojek.eu>
>>  > ---
>> 
>>  Queued for usb-next. Thanks.
> 
> I removed this and the next patch [3/7] in this series from my queue.
> Sorry. Ming Guo has posted a series "Add MediaTek MUSB Controller
> Driver" which has done the similar implementation [1] but without 
> adding
> the flag in struct musb. Can you please check if you can use Ming's
> implementation instead? The patch of his musb glue driver which uses 
> the
> implementation is [2], just for your reference.

Sure. Were these patches merged? What tree do they apply to? They don't 
apply cleanly on -rc2.

-Paul


> 
> [1] https://marc.info/?l=linux-usb&m=157602930627195&w=2
> [2] https://marc.info/?l=linux-usb&m=157602932427210&w=2
> 
> Thanks,
> -Bin.