linux-kernel - Re: [PATCH net-next 1/3] net: emaclite: Fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191217.135729.173497629676380262.davem@davemloft.net>
Date:   Tue, 17 Dec 2019 13:57:29 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     radhey.shyam.pandey@...inx.com
Cc:     michal.simek@...inx.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        git@...inx.com
Subject: Re: [PATCH net-next 1/3] net: emaclite: Fix coding style

From: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
Date: Mon, 16 Dec 2019 17:38:08 +0530

> -	spinlock_t reset_lock;
> +	spinlock_t reset_lock; /* lock used for synchronization */

If you're just going to put the comment there to shut up the warnings,
I'm not applying your patches.

You have to write a thoughtful comment which explains what this lock
actually protects.