[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <286c11c2-480f-37d6-e9fe-91822f862cd6@linux.alibaba.com>
Date: Tue, 17 Dec 2019 09:30:13 +0800
From: Alex Shi <alex.shi@...ux.alibaba.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, akpm@...ux-foundation.org,
mgorman@...hsingularity.net, tj@...nel.org, hughd@...gle.com,
khlebnikov@...dex-team.ru, daniel.m.jordan@...cle.com,
yang.shi@...ux.alibaba.com, shakeelb@...gle.com,
hannes@...xchg.org, Michal Hocko <mhocko@...nel.org>,
Vladimir Davydov <vdavydov.dev@...il.com>,
Roman Gushchin <guro@...com>,
Chris Down <chris@...isdown.name>,
Thomas Gleixner <tglx@...utronix.de>,
Vlastimil Babka <vbabka@...e.cz>, Qian Cai <cai@....pw>,
Andrey Ryabinin <aryabinin@...tuozzo.com>,
"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
Jérôme Glisse <jglisse@...hat.com>,
Andrea Arcangeli <aarcange@...hat.com>,
David Rientjes <rientjes@...gle.com>,
"Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
swkhack <swkhack@...il.com>,
"Potyra, Stefan" <Stefan.Potyra@...ktrobit.com>,
Mike Rapoport <rppt@...ux.vnet.ibm.com>,
Stephen Rothwell <sfr@...b.auug.org.au>,
Colin Ian King <colin.king@...onical.com>,
Jason Gunthorpe <jgg@...pe.ca>,
Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
Peng Fan <peng.fan@....com>,
Nikolay Borisov <nborisov@...e.com>,
Ira Weiny <ira.weiny@...el.com>,
Kirill Tkhai <ktkhai@...tuozzo.com>,
Yafang Shao <laoar.shao@...il.com>
Subject: Re: [PATCH v6 02/10] mm/lru: replace pgdat lru_lock with lruvec lock
在 2019/12/16 下午8:14, Matthew Wilcox 写道:
> On Mon, Dec 16, 2019 at 05:26:18PM +0800, Alex Shi wrote:
>> -static void lock_page_lru(struct page *page, int *isolated)
>> +static struct lruvec *lock_page_lru(struct page *page, int *isolated)
>> {
>> - pg_data_t *pgdat = page_pgdat(page);
>> + struct lruvec *lruvec = lock_page_lruvec_irq(page);
>>
>> - spin_lock_irq(&pgdat->lru_lock);
>> if (PageLRU(page)) {
>> - struct lruvec *lruvec;
>>
>> - lruvec = mem_cgroup_page_lruvec(page, pgdat);
>> ClearPageLRU(page);
>> del_page_from_lru_list(page, lruvec, page_lru(page));
>> *isolated = 1;
>> } else
>> *isolated = 0;
>> +
>> + return lruvec;
>> }
>
> You still didn't fix this function. Go back and look at my comment from
> the last time you sent this patch set.
>
Sorry for the misunderstanding. I guess what your want is fold the patch 9th into this, is that right?
Any comments for the 9th patch?
Thanks
Alex
Powered by blists - more mailing lists