linux-kernel - Re: [PATCH v2 1/2] pwm: fine tune pwm-mtk-disp clock control flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1576550522.19567.1.camel@mszsdaap41>
Date:   Tue, 17 Dec 2019 10:42:02 +0800
From:   Jitao Shi <jitao.shi@...iatek.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
CC:     Thierry Reding <thierry.reding@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-pwm@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, CK Hu <ck.hu@...iatek.com>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <sj.huang@...iatek.com>
Subject: Re: [PATCH v2 1/2] pwm: fine tune pwm-mtk-disp clock control flow

On Mon, 2019-12-16 at 09:18 +0100, Uwe Kleine-König wrote:
> Hello,
> 
> On Mon, Dec 16, 2019 at 03:01:22PM +0800, Jitao Shi wrote:
> > Match pwm clock when suspend and resume.
> > Prepare and enable disp_pwm clock when disp_pwm enable.
> > Disable and unprepare disp_pwm clock when disp_pwm disable.
> 
> Assuming you catched all clock operations (I didn't check), the patch
> looks fine. The commit log could however be improved. Additional to
> describing what the patch does, some words about the motivation would be
> good. Does this fix a bug? Is it to save some power while the PWM isn't
> in use?
> 
> Best regards
> Uwe
> 

I'll update the commit msg next version.

Thanks for your review.

Best Regards
Jitao