linux-kernel - Re: [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8afc1bc6551c81ff84b8ac9fd86aed14ed7b7240.camel@linux.intel.com>
Date:   Tue, 17 Dec 2019 02:43:50 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jerry Snitselaar <jsnitsel@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Christian Bundy <christianbundy@...ction.io>,
        Dan Williams <dan.j.williams@...el.com>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        stable@...r.kernel.org, linux-intergrity@...r.kernel.org
Subject: Re: [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core_init

On Wed, 2019-12-11 at 16:17 -0700, Jerry Snitselaar wrote:
> Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when
> issuing commands to the tpm during initialization, just reserve the
> chip after wait_startup, and release it when we are ready to call
> tpm_chip_register.
> 
> Cc: Christian Bundy <christianbundy@...ction.io>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Peter Huewe <peterhuewe@....de>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: Stefan Berger <stefanb@...ux.vnet.ibm.com>
> Cc: stable@...r.kernel.org
> Cc: linux-intergrity@...r.kernel.org
> Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
> Signed-off-by: Jerry Snitselaar <jsnitsel@...hat.com>

Sorry for the latency.

For me this looks good for putting to my rc3 PR with a minor twist:

1. Rename out_err as err_probe.
2. Rename out_start as err_start.

/Jarkko