linux-kernel - Re: [PATCH] iio: adc: at91: Use dma_request_chan() instead dma_request_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 07:59:34 +0000
From:   <Eugen.Hristev@...rochip.com>
To:     <peter.ujfalusi@...com>, <jic23@...nel.org>
CC:     <vkoul@...nel.org>, <Ludovic.Desroches@...rochip.com>,
        <linux-iio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: at91: Use dma_request_chan() instead
 dma_request_slave_channel()



On 17.12.2019 09:50, Peter Ujfalusi wrote:

> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
> 
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
>   drivers/iio/adc/at91-sama5d2_adc.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Hi Peter,

Thank you for the patch.
Nitpick : at91 is another driver (old one for different platforms), so 
can you please change the commit oneline to iio: adc: at91-sama5d2_adc: 
to not be confused about which driver is affected.

Thanks !
Eugen

> 
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index e1850f3d5cf3..a5c7771227d5 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -1444,10 +1444,10 @@ static void at91_adc_dma_init(struct platform_device *pdev)
>          if (st->dma_st.dma_chan)
>                  return;
> 
> -       st->dma_st.dma_chan = dma_request_slave_channel(&pdev->dev, "rx");
> -
> -       if (!st->dma_st.dma_chan)  {
> +       st->dma_st.dma_chan = dma_request_chan(&pdev->dev, "rx");
> +       if (IS_ERR(st->dma_st.dma_chan))  {
>                  dev_info(&pdev->dev, "can't get DMA channel\n");
> +               st->dma_st.dma_chan = NULL;
>                  goto dma_exit;
>          }
> 
> --
> Peter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> 
>