linux-kernel - Re: [PATCH] [staging-next] isdn: don't mark kcapi_proc_exit as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191217080054.GA2525210@kroah.com>
Date:   Tue, 17 Dec 2019 09:00:54 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     kbuild test robot <lkp@...el.com>,
        "kernelci . org bot" <bot@...nelci.org>,
        Olof's autobuilder <build@...om.net>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Karsten Keil <isdn@...ux-pingi.de>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [staging-next] isdn: don't mark kcapi_proc_exit as __exit

On Mon, Dec 16, 2019 at 08:48:56PM +0100, Arnd Bergmann wrote:
> As everybody pointed out by now, my patch to clean up CAPI introduced
> a link time warning, as the two parts of the capi driver are now in
> one module and the exit function may need to be called in the error
> path of the init function:
> 
> >> WARNING: drivers/isdn/capi/kernelcapi.o(.text+0xea4): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit()
>    The function kcapi_exit() references a function in an exit section.
>    Often the function kcapi_proc_exit() has valid usage outside the exit section
>    and the fix is to remove the __exit annotation of kcapi_proc_exit.
> 
> Remove the incorrect __exit annotation.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Reported-by: kernelci.org bot <bot@...nelci.org>
> Reported-by: Olof's autobuilder <build@...om.net>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/isdn/capi/kcapi_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for this, now applied.

greg k-h