linux-kernel - Re: [PATCH v2] selftests: livepatch: Fix it to do root uid check and skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191217090210.ky3il3qu4jkr2vaa@pathway.suse.cz>
Date:   Tue, 17 Dec 2019 10:02:10 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     jpoimboe@...hat.com, jikos@...nel.org, mbenes@...e.cz,
        joe.lawrence@...hat.com, shuah@...nel.org,
        live-patching@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftests: livepatch: Fix it to do root uid check and
 skip

On Mon 2019-12-16 12:18:40, Shuah Khan wrote:
> livepatch test configures the system and debug environment to run
> tests. Some of these actions fail without root access and test
> dumps several permission denied messages before it exits.
> 
> Fix test-state.sh to call setup_config instead of set_dynamic_debug
> as suggested by Petr Mladek <pmladek@...e.com>
> 
> Fix it to check root uid and exit with skip code instead.
> 
> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>

Reviewed-by: Petr Mladek <pmladek@...e.com>

Shuah, I assume that you will push this fix via linux-kselftest tree.
Please, tell us if you have other preference.

Best Regards,
Petr