linux-kernel - Re: [PATCH v6 09/15] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f56acdc65ab341f9c4ec0709fbfcc32b9f16d6ae.camel@fi.rohmeurope.com>
Date:   Tue, 17 Dec 2019 09:15:48 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "broonie@...nel.org" <broonie@...nel.org>
CC:     "corbet@....net" <corbet@....net>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "phil.edworthy@...esas.com" <phil.edworthy@...esas.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "dmurphy@...com" <dmurphy@...com>,
        "wsa+renesas@...g-engineering.com" <wsa+renesas@...g-engineering.com>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "jacek.anaszewski@...il.com" <jacek.anaszewski@...il.com>,
        "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "noralf@...nnes.org" <noralf@...nnes.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "pavel@....cz" <pavel@....cz>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "sboyd@...nel.org" <sboyd@...nel.org>
Subject: Re: [PATCH v6 09/15] regulator: bd71828: Basic support for ROHM
 bd71828 PMIC regulators

Hello Mark,

On Mon, 2019-12-16 at 14:55 +0000, Mark Brown wrote:
> On Wed, Dec 11, 2019 at 11:46:11AM +0200, Matti Vaittinen wrote:
> 
> > +static int bd71828_ldo6_get_voltage(struct regulator_dev *rdev)
> > +{
> > +	return BD71828_LDO_6_VOLTAGE;
> > +}
> > +
> > +static const struct regulator_ops bd71828_ldo6_ops = {
> > +	.enable = regulator_enable_regmap,
> > +	.disable = regulator_disable_regmap,
> > +	.get_voltage = bd71828_ldo6_get_voltage,
> 
> You can just set fixed_uV in the regulator_desc, you don't need a
> get_voltage() operation here.  Otherwise this looks good, I'll apply
> it
> and please send an incremental fix for this.

Just to confirm - are you also taking in the
[PATCH v6 08/15] regulator: bd718x7: Split driver to common and bd718x7
specific parts

I think there is a dependency. (I am preparing next version of the
series so I'll drop the already applied patches.)

Br,
	Matti Vaittinen