linux-kernel - Re: [PATCH] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 15:19:52 +0530
From:   Akash Asthana <akashast@...eaurora.org>
To:     Stephen Boyd <swboyd@...omium.org>, agross@...nel.org,
        bjorn.andersson@...aro.org, mark.rutland@....com,
        robh+dt@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, mgautam@...eaurora.org
Subject: Re: [PATCH] dt-bindings: geni-se: Convert QUP geni-se bindings to
 YAML


On 12/16/2019 10:12 PM, Stephen Boyd wrote:
> Quoting Akash Asthana (2019-12-16 01:25:51)
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> new file mode 100644
>> index 0000000..2c3b911
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> @@ -0,0 +1,196 @@
> [...]
>> +
>> +  "serial@[0-9]+$":
>> +    type: object
>> +    description: GENI Serial Engine based UART Controller.
>> +
>> +    properties:
>> +      compatible:
>> +        enum:
>> +          - qcom,geni-uart
>> +          - qcom,geni-debug-uart
>> +
>> +      reg:
>> +        description: GENI Serial Engine register address and length.
>> +
>> +      interrupts:
>> +        description: Contains UART core and wakeup interrupts for wakeup
>> +                     capable UART devices. We configure wakeup interrupt
>> +                     on UART RX line using TLMM interrupt controller.
>> +        maxItems: 2
> Shouldn't there be a minItems: 1 here? And then you should specify the order?
> Presumably something like
>
> 	interrupts:
> 	  minItems: 1
> 	  maxItems: 2
> 	  items:
> 	    - description: UART core irq
> 	    - description: Wakeup irq (RX GPIO)

Yeah ok, Thanks for correction.

I will update this in next version.

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project