linux-kernel - Re: [PATCH 5/5] dt-bindings: pinctrl: dw: move sps,dwapb-gpio.txt to pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1686073939.96973784.1576576905628.JavaMail.zimbra@kalray.eu>
Date:   Tue, 17 Dec 2019 11:01:45 +0100 (CET)
From:   Clément Leger <cleger@...ray.eu>
To:     Rob Herring <robh@...nel.org>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Mark Rutland <mark.rutland@....com>,
        Hoan Tran <hoan@...amperecomputing.com>,
        "open list, GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH 5/5] dt-bindings: pinctrl: dw: move sps,dwapb-gpio.txt
 to pinctrl

Hi Rob, 

Indeed, I could do that if you think that's a better option. Andy however suggested to always register a pinctrl controller.
Both options suits me. Let me know what option you want me to implement.

Thanks,

Clément

----- On 16 Dec, 2019, at 22:39, Rob Herring robh@...nel.org wrote:

> On Wed, Dec 04, 2019 at 02:52:59PM +0100, Clément Leger wrote:
>> 
>> ----- On 4 Dec, 2019, at 13:45, Andy Shevchenko andy.shevchenko@...il.com wrote:
>> 
>> > On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@...ray.eu> wrote:
>> >>
>> >> Since the driver has been moved to pinctrl and now supports it, move the
>> >> documentation into pinctrl folder. In the same time, add documentation
>> >> for pinctrl properties such has snps,has-pinctrl and description of pin
>> >> alternate functions.
>> > 
>> >> +- snps,has-pinctrl : If present, register the pinctrl controller.
>> > 
>> > I'm wondering why we can't always assume pin control?
>> 
>> This hardware IP is configured when instantiated to include support for
>> muxing. If configured without support, the registers will exists but won't
>> configure anything.
>> I guess that it's not really a problem but it will lead to unusable
>> pin muxing.
> 
> Can't you determine this by the presence of child nodes?
> 
> Rob