[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51f73b85b2a9a9f3d72f2776617be9c9@codeaurora.org>
Date: Tue, 17 Dec 2019 15:41:44 +0530
From: Sibi Sankar <sibis@...eaurora.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: bjorn.andersson@...aro.org, rnayak@...eaurora.org,
robh+dt@...nel.org, agross@...nel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org, mark.rutland@....com,
dianders@...omium.org, linux-kernel-owner@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: rpmpd: Convert rpmpd bindings to
yaml
On 2019-12-17 01:05, Stephen Boyd wrote:
> Quoting Sibi Sankar (2019-12-16 03:55:30)
>> Convert RPM/RPMH power-domain bindings to yaml.
>>
>> Signed-off-by: Sibi Sankar <sibis@...eaurora.org>
>
> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
>
> One nitpick below!
>
>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> new file mode 100644
>> index 0000000000000..4aebf024e4427
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> @@ -0,0 +1,170 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/power/qcom,rpmpd.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm RPM/RPMh Power domains
>> +
>> +maintainers:
>> + - Rajendra Nayak <rnayak@...eaurora.org>
>> +
>> +description:
>> + For RPM/RPMh Power domains, we communicate a performance state to
>> RPM/RPMh
>> + which then translates it into a corresponding voltage on a rail
>
> Add a full-stop here to make it a true sentence?
sure I'll re-spin it
>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,msm8976-rpmpd
>> + - qcom,msm8996-rpmpd
>> + - qcom,msm8998-rpmpd
>> + - qcom,qcs404-rpmpd
>> + - qcom,sc7180-rpmhpd
>> + - qcom,sdm845-rpmhpd
>> + - qcom,sm8150-rpmhpd
>> +
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
Powered by blists - more mailing lists