linux-kernel - Re: [PATCH 5/5] locking/percpu-rwsem: Remove the embedded rwsem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191217102824.GB2844@hirez.programming.kicks-ass.net>
Date:   Tue, 17 Dec 2019 11:28:24 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Waiman Long <longman@...hat.com>
Cc:     mingo@...nel.org, will@...nel.org, oleg@...hat.com,
        tglx@...utronix.de, linux-kernel@...r.kernel.org,
        bigeasy@...utronix.de, juri.lelli@...hat.com, williams@...hat.com,
        bristot@...hat.com, dave@...olabs.net, jack@...e.com
Subject: Re: [PATCH 5/5] locking/percpu-rwsem: Remove the embedded rwsem

On Mon, Nov 18, 2019 at 04:52:23PM -0500, Waiman Long wrote:
> On 11/13/19 5:21 AM, Peter Zijlstra wrote:
> > @@ -130,20 +131,12 @@ static inline void percpu_rwsem_release(
> >  					bool read, unsigned long ip)
> >  {
> >  	lock_release(&sem->dep_map, ip);
> > -#ifdef CONFIG_RWSEM_SPIN_ON_OWNER
> > -	if (!read)
> > -		atomic_long_set(&sem->rw_sem.owner, RWSEM_OWNER_UNKNOWN);
> > -#endif
> >  }
> >  
> 
> This is the only place that set RWSEM_OWNER_UNKNOWN. So you may as well
> remove all references to it:

Done, thanks!