linux-kernel - Re: [PATCH v3 2/4] iio: adc: ad7923: Fix checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2d3c5ce9015d00c5b3c82bfffd3f3e03b4246b7.camel@analog.com>
Date:   Tue, 17 Dec 2019 11:30:09 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "lkcamp@...ts.libreplanetbr.org" <lkcamp@...ts.libreplanetbr.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "djunho@...il.com" <djunho@...il.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "knaack.h@....de" <knaack.h@....de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "Popa, Stefan Serban" <StefanSerban.Popa@...log.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/4] iio: adc: ad7923: Fix checkpatch warning

On Tue, 2019-12-17 at 08:11 -0300, Daniel Junho wrote:
> Fix checkpatch warning:
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +static int ad7923_scan_direct(struct ad7923_state *st, unsigned ch)
> 

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@...log.com>

> Signed-off-by: Daniel Junho <djunho@...il.com>
> ---
>  drivers/iio/adc/ad7923.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c
> index 969c06b7d2b7..e535cec9fc02 100644
> --- a/drivers/iio/adc/ad7923.c
> +++ b/drivers/iio/adc/ad7923.c
> @@ -184,7 +184,7 @@ static irqreturn_t ad7923_trigger_handler(int irq,
> void *p)
>  	return IRQ_HANDLED;
>  }
>  
> -static int ad7923_scan_direct(struct ad7923_state *st, unsigned ch)
> +static int ad7923_scan_direct(struct ad7923_state *st, unsigned int ch)
>  {
>  	int ret, cmd;
>