linux-kernel - Re: [PATCH] perf/core: Add SRCU annotation for pmus list walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191217114837.4jkyg3uojyu3f4qr@linutronix.de>
Date:   Tue, 17 Dec 2019 12:48:37 +0100
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Joel Fernandes <joel@...lfernandes.org>
Cc:     linux-kernel@...r.kernel.org,
        "Paul E. McKenney" <paulmck@...ux.ibm.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] perf/core: Add SRCU annotation for pmus list walk

On 2019-11-29 15:05:22 [-0500], Joel Fernandes wrote:
> On Tue, Nov 19, 2019 at 01:14:29PM +0100, Sebastian Andrzej Siewior wrote:
> > Since commit
> >    28875945ba98d ("rcu: Add support for consolidated-RCU reader checking")
> > 
> > there is an additional check to ensure that a RCU related lock is held
> > while the RCU list is iterated.
> > This section holds the SRCU reader lock instead.
> > 
> > Add annotation to list_for_each_entry_rcu() that pmus_srcu must be
> > acquired during the list traversal.
> > 
> 
> Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>
> 
> thanks,
> 
>  - Joel
> 
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> > ---
> > 
> > I see the warning in in v5.4-rc during boot. For some reason I don't see
> > it in tip/master during boot but "perf stat w" triggers it again (among
> > other things).

kind ping

Sebastian