linux-kernel - Re: [PATCH V2 3/3] arm64: defconfig: Enable CRYPTO_DEV_FSL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHCN7xLrX0R7Uag2vc1qMp4z=1r3haCWrcp4qJT0H0eC3RiA4Q@mail.gmail.com>
Date:   Tue, 17 Dec 2019 07:07:22 -0600
From:   Adam Ford <aford173@...il.com>
To:     Horia Geanta <horia.geanta@....com>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Aymen Sghaier <aymen.sghaier@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH V2 3/3] arm64: defconfig: Enable CRYPTO_DEV_FSL_CAAM

On Tue, Dec 17, 2019 at 3:11 AM Horia Geanta <horia.geanta@....com> wrote:
>
> On 12/13/2019 5:39 PM, Adam Ford wrote:
> > Both the i.MX8MQ and i.MX8M Mini support the CAAM driver, but it
> So do the Layerscape ARMv8-based SoCs:
> LS1012A, LS1028A, LS1043A, LS1046A, LS1088A, LS2088A, LX2160A
>
> > is currently not enabled by default.
> >
> > This patch enables this driver by default.
> >
> > Signed-off-by: Adam Ford <aford173@...il.com>
> > ---
> > V2:  New to series
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 6a83ba2aea3e..0212975b908b 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -845,6 +845,7 @@ CONFIG_SECURITY=y
> >  CONFIG_CRYPTO_ECHAINIV=y
> >  CONFIG_CRYPTO_ANSI_CPRNG=y
> >  CONFIG_CRYPTO_DEV_SUN8I_CE=m
> > +CONFIG_CRYPTO_DEV_FSL_CAAM=y
> This should probably be "m" instead.

Out of curiosity, what is the rule for when things are 'm' vs 'y'?

In the Code Aurora repo, it is set to 'y' and the mainline kernel for
the i.MX6/7, the imx_v6_v7_defconfig is also set to 'y' which is why I
used 'y' here.

I can do a V3 to address the other items you noted, but I want to
understand the rules about the defconfig so I don't make the same
mistake again.

thanks,

adam
>
> Horia