linux-kernel - Re: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191217133234.GB3362771@kroah.com>
Date:   Tue, 17 Dec 2019 14:32:34 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Dave Kim <david.kim@...pher.com>
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org,
        Tim Magee <tim.magee@...pher.com>
Subject: Re: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices

On Tue, Dec 17, 2019 at 01:22:44PM +0000, Dave Kim wrote:
> From: David Kim <david.kim@...pher.com>
> 
> Introduce the driver for nCipher's Solo and Solo XC range of PCIe hardware
> security modules (HSM), which provide key creation/management and
> cryptography services.

A bit more description of exactly _what_ these devices do would be
helpful.

Also, how does userspace interact with the driver?  What api(s) are you
using/creating?  What userspace tools work with the device?

In short, we need more than just a one sentance description to be able
to properly review the code and provide text for a user to know what to
do with this driver.

Can you fix all that up and send a v2?

thanks,

greg k-h