linux-kernel - Re: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191217133834.GE3362771@kroah.com>
Date:   Tue, 17 Dec 2019 14:38:34 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Dave Kim <david.kim@...pher.com>
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org,
        Tim Magee <tim.magee@...pher.com>
Subject: Re: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices

On Tue, Dec 17, 2019 at 01:22:44PM +0000, Dave Kim wrote:
> +/**
> + * PCI device ID table.  We use the driver_data field to hold an index into
> + * nfp_drvlist, so bear than in mind when editing either.
> + */
> +static struct pci_device_id nfp_pci_tbl[] = {
> +	{
> +		PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_21555,
> +		PCI_VENDOR_ID_NCIPHER, PCI_SUBSYSTEM_ID_NFAST_REV1, 0,
> +		0, /* Ignore class */
> +		0 /* Index into nfp_drvlist */

Please use the correct PCI_DEVICE() macros, that should work here,
right?

And you are grabbing an Intel PCI device id?

> +	},
> +	{
> +		PCI_VENDOR_ID_FREESCALE, PCI_DEVICE_ID_FREESCALE_T1022,
> +		PCI_VENDOR_ID_NCIPHER, PCI_SUBSYSTEM_ID_NFAST_REV1, 0,
> +		0, /* Ignore class */
> +		1 /* Index into nfp_drvlist */

Again, PCI_DEVICE() macros please.

And kerneldoc everywhere, your commenting format for all of the code is
a bit "odd".

thanks,

greg k-h