linux-kernel - [PATCH] scsi:libfc:fix fc_lport_ptp_setup(): Null pointer dereferences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <EDBAAA0BBBA2AC4E9C8B6B81DEEE1D6915E9AA36@dggeml505-mbx.china.huawei.com>
Date:   Tue, 17 Dec 2019 14:26:27 +0000
From:   "wubo (T)" <wubo40@...wei.com>
To:     "hare@...e.de" <hare@...e.de>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "James.Bottomley@...e.de" <James.Bottomley@...e.de>,
        "robert.w.love@...el.com" <robert.w.love@...el.com>,
        "jeykholt@...co.com" <jeykholt@...co.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Mingfangsen <mingfangsen@...wei.com>
Subject: [PATCH] scsi:libfc:fix fc_lport_ptp_setup(): Null pointer
 dereferences

From: Wu Bo <wubo40@...wei.com>

The code following:
fc_rport_create()
    ...
    rdata = kzalloc(sizeof(*rdata) + lport->rport_priv_size, GFP_KERNEL);
    if (!rdata)
        return NULL;
    ...

fc_lport_ptp_setup()
   ...
   lport->ptp_rdata = fc_rport_create(lport, remote_fid);
   kref_get(&lport->ptp_rdata->kref);
   lport->ptp_rdata->ids.port_name = remote_wwpn;
   ...

Fix by adding a check for lport->ptp_rdata before be used on fc_lport_ptp_setup func.

Signed-off-by: Wu Bo <wubo40@...wei.com>
---
 drivers/scsi/libfc/fc_lport.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c
index 684c5e3..36e7bdd 100644
--- a/drivers/scsi/libfc/fc_lport.c
+++ b/drivers/scsi/libfc/fc_lport.c
@@ -238,6 +238,10 @@ static void fc_lport_ptp_setup(struct fc_lport *lport,
        }
        mutex_lock(&lport->disc.disc_mutex);
        lport->ptp_rdata = fc_rport_create(lport, remote_fid);
+       if (!lport->ptp_rdata) {
+               mutex_unlock(&lport->disc.disc_mutex);
+               return;
+       }
        kref_get(&lport->ptp_rdata->kref);
        lport->ptp_rdata->ids.port_name = remote_wwpn;
        lport->ptp_rdata->ids.node_name = remote_wwnn;
--
1.8.3.1