linux-kernel - Re: [PATCH] Input: axp20x-pek - make device attributes static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Dec 2019 11:00:00 +0800
From:   Chen-Yu Tsai <wens@...nel.org>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: axp20x-pek - make device attributes static

On Tue, Dec 17, 2019 at 11:25 PM Ben Dooks (Codethink)
<ben.dooks@...ethink.co.uk> wrote:
>
> The two device attrbitues are not declared outside this file
> so make them static to avoid the following warnings:
>
> drivers/input/misc/axp20x-pek.c:194:1: warning: symbol 'dev_attr_startup' was not declared. Should it be static?
> drivers/input/misc/axp20x-pek.c:195:1: warning: symbol 'dev_attr_shutdown' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>
> ---
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Chen-Yu Tsai <wens@...e.org>
> Cc: linux-input@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org

Acked-by: Chen-Yu Tsai <wens@...e.org>